Feature/dialog #688
Merged
Feature/dialog #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
==========================================
+ Coverage 72.88% 73.64% +0.76%
==========================================
Files 161 169 +8
Lines 4385 4542 +157
Branches 338 348 +10
==========================================
+ Hits 3196 3345 +149
- Misses 1122 1125 +3
- Partials 67 72 +5
|
nnixaa
requested changes
Sep 11, 2018
| open() { | ||
| this.dialogService.open(NbDialogComponent, { | ||
| context: { | ||
| title: 'This is title passed to the dialog component', |
| </ng-template> | ||
| <button class="btn btn-primary" (click)="open(dialog)">Open Dialog</button> | ||
| `, | ||
| styles: [` /deep/ nb-layout-column { |
nnixaa
requested changes
Sep 11, 2018
| import { NbDialogRef } from '@nebular/theme'; | ||
|
|
||
| @Component({ | ||
| selector: 'nb-dialog', |
There was a problem hiding this comment.
copy to the each of the examples
Tibing
force-pushed
the
feature/dialog
branch
from
4318c51
to
635cc78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #666, Closes #665