Feature/overlay #679
Merged
Feature/overlay #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnixaa
requested changes
Sep 10, 2018
| { provide: ScrollDispatcher, useClass: NbScrollDispatcherAdapter }, | ||
| ], | ||
| }) | ||
| export class NbAdapterModule { |
There was a problem hiding this comment.
NbCdkAdapter maybe? As NbAdapterModule is too abstract to me
|
|
||
| @Injectable() | ||
| export class NbScrollDispatcherAdapter extends ScrollDispatcher { | ||
| constructor(_ngZone: NgZone, _platform: NbPlatform, protected scrollService: NbLayoutScrollService) { |
| super(_platform, ngZone); | ||
| } | ||
|
|
||
| getViewportSize(): Readonly<{ width: number; height: number; }> { |
There was a problem hiding this comment.
let's add a comment why this is a synchronous operation
| @@ -0,0 +1,5 @@ | |||
| @mixin nb-overlay-theme { | |||
| .overlay-backdrop { | |||
| background: rgba(0, 0, 0, 0.288); | |||
There was a problem hiding this comment.
this looks like a theme variable to me
| export abstract class NbPositionedContainer { | ||
| @Input() position: NbPosition; | ||
|
|
||
| @HostBinding('class.top') |
There was a problem hiding this comment.
should we make this class more specific? That would be safer
| if (this.isComponent) { | ||
| Object.assign(el._componentRef.instance, this.context); | ||
| /** | ||
| * Change detection have to performed here, because another way applied context |
| @@ -4,6 +4,7 @@ | |||
| * Licensed under the MIT License. See License.txt in the project root for license information. | |||
| */ | |||
|
|
|||
| @import '~@angular/cdk/overlay-prebuilt.css'; | |||
There was a problem hiding this comment.
what styles does it include?
nnixaa
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Add nebular cdk module, which is a wrapper over angular cdk and provides some nebular specific features. Such as overrides of the overlay module.
Closes #661, closes #660.