Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu) #621

Merged
merged 13 commits into from
Aug 13, 2018
Merged

fix(menu) #621

merged 13 commits into from
Aug 13, 2018

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Aug 10, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes: #620, #369, #532, #307, #444, #392, akveo/ngx-admin#1703, akveo/ngx-admin#1819

@yggg yggg added the WIP label Aug 10, 2018
@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #621 into master will decrease coverage by 0.09%.
The diff coverage is 17.24%.

@@            Coverage Diff            @@
##           master     #621     +/-   ##
=========================================
- Coverage   72.81%   72.71%   -0.1%     
=========================================
  Files         153      153             
  Lines        4219     4222      +3     
  Branches      318      323      +5     
=========================================
- Hits         3072     3070      -2     
- Misses       1090     1095      +5     
  Partials       57       57
Impacted Files Coverage Δ
.../framework/theme/components/menu/menu.component.ts 37.28% <40.9%> (+4.95%) ⬆️
...rc/framework/theme/components/menu/menu.service.ts 32.6% <9.23%> (-7.4%) ⬇️

@yggg yggg removed the WIP label Aug 13, 2018
@nnixaa nnixaa merged commit 7542d5e into akveo:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Menu Item(s) Appear Selected Despite Not Being the Active Page
2 participants