Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): ability to assign an icon #607

Merged
merged 5 commits into from
Aug 7, 2018
Merged

feat(tabs): ability to assign an icon #607

merged 5 commits into from
Aug 7, 2018

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Aug 7, 2018

Closes #288

@nnixaa nnixaa requested a review from Tibing August 7, 2018 09:58
@Tibing
Copy link
Member

Tibing commented Aug 7, 2018

Icons not centered correctly because of this empty span.
image

@nnixaa nnixaa merged commit b78b8d3 into master Aug 7, 2018
@nnixaa nnixaa deleted the feat/tab-icon branch August 7, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants