Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): fix disable state with reactive forms #599

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

mrchops1024
Copy link
Contributor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

When using nb-checkbox with reactive forms, disabling the form control does not disable the underlying input. Implementing the setDisabledState method fixes this issue. See #296 for the initial report.

@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #599 into master will increase coverage by 0.09%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #599      +/-   ##
=========================================
+ Coverage    70.5%   70.6%   +0.09%     
=========================================
  Files         124     124              
  Lines        3590    3592       +2     
  Branches      260     260              
=========================================
+ Hits         2531    2536       +5     
+ Misses       1010    1007       -3     
  Partials       49      49
Impacted Files Coverage Δ
...rk/theme/components/checkbox/checkbox.component.ts 93.93% <100%> (+10.06%) ⬆️

@nnixaa nnixaa merged commit 7d8beea into akveo:master Aug 6, 2018
@nnixaa
Copy link
Collaborator

nnixaa commented Aug 6, 2018

@mrchops1024 cool, thanks! 👍

@mrchops1024 mrchops1024 deleted the fix/nb-checkbox-reactive-disable branch August 6, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants