Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/auth button input #595

Merged
merged 3 commits into from
Aug 1, 2018
Merged

Feat/auth button input #595

merged 3 commits into from
Aug 1, 2018

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Jul 31, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #595 into master will decrease coverage by 0.16%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   69.88%   69.72%   -0.17%     
==========================================
  Files         120      120              
  Lines        3457     3465       +8     
  Branches      247      247              
==========================================
  Hits         2416     2416              
- Misses        995     1003       +8     
  Partials       46       46
Impacted Files Coverage Δ
src/framework/auth/auth.module.ts 86.48% <100%> (ø) ⬆️
...ork/auth/components/register/register.component.ts 23.68% <33.33%> (-1.32%) ⬇️
...nts/request-password/request-password.component.ts 25% <33.33%> (-1.48%) ⬇️
...framework/auth/components/login/login.component.ts 23.68% <33.33%> (-1.32%) ⬇️
...ponents/reset-password/reset-password.component.ts 25% <33.33%> (-1.48%) ⬇️

BREAKING CHANGE:
possible breaking change since we don't use bootstrap inputs and buttons anymore
and use Nebular components instead
@nnixaa nnixaa requested a review from Tibing July 31, 2018 16:01
@nnixaa nnixaa merged commit e1863ec into master Aug 1, 2018
@nnixaa nnixaa deleted the feat/auth-button-input branch August 1, 2018 09:22
@Prefix1802
Copy link
Contributor

Hi Guys and Girls

Nebular is indeed broken now because of the use of nb-alert and input nbInput in ...framework/auth/components/login/login.component.ts,

When u try to implement a custom login as described in https://akveo.github.io/nebular/docs/auth/configuring-ui#custom-ui-components these tags are not recognized because the @nebular directory in ngx-admin is not complete. Even when i try to reinstall Nebular modules with npm i -S @nebular/theme @nebular/auth @nebular/security.

An example of missing direcory in ngx-admin is ngx-admin-master\node_modules@nebular\theme\components. In fact there are more directories missing.

Can you please fix this ASAP?

with kind regards,

Clyde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants