feature/auth : added a back link to the strategy name in the token (future use for instance refreshToken) #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now : If existing, NbAuthResult contains backend error description other Changes requested by Dmitry (first review)
Now : If existing, NbAuthResult contains backend error description other Changes requested by Dmitry (first review) +tslint missing trailing comma arghhh
…strategy used to create the token (future use)
The token now contains ownerStrategyName, with is a back link to the strategy used to create the token (future use). BREAKING CHANGE : NbAuthCreateToken (token.ts) now takes a third parameter, which is the ownerStrategyName Tokens are created by strategies that are called from services, so it is *potentially* a breaking change.
The token now contains ownerStrategyName, with is a back link to the strategy used to create the token (future use). updated unit tests files and oauth2-password-login.component (breaking change below) BREAKING CHANGE : NbAuthCreateToken (token.ts) now takes a third parameter, which is the ownerStrategyName Tokens are created by strategies that are called from services, so it is *potentially* a breaking change.
nnixaa
requested changes
Jul 20, 2018
| export function nbAuthCreateToken(tokenClass: NbAuthTokenClass, token: any) { | ||
| return new tokenClass(token); | ||
| // All types of token are not refreshables | ||
| export function isNbAuthRefreshableToken(token: any): token is NbAuthRefreshableToken { |
There was a problem hiding this comment.
I guess this is not a part of this PR, isn't it?
There was a problem hiding this comment.
you're right. Part of the next next next :)
| // we may get it as string when retrieving from a storage | ||
| super(prepareOAuth2Token(data)); | ||
| super(prepareOAuth2Token(data), ownerStrategyName); | ||
| this.ownerStrategyName = ownerStrategyName; |
There was a problem hiding this comment.
why to assign it here again as it will be assigned in super?
| @@ -26,7 +26,7 @@ describe('password-auth-strategy', () => { | |||
| }, | |||
| }; | |||
|
|
|||
| const successToken = nbAuthCreateToken(NbAuthSimpleToken, 'token'); | |||
| const successToken = nbAuthCreateToken(NbAuthSimpleToken, 'token', 'strategy'); | |||
There was a problem hiding this comment.
let's move name of the strategy strategy to a variable
removed useless code and cleaned one unit test file BREAKING CHANGE : NbAuthCreateToken (token.ts) now takes a third parameter, which is the ownerStrategyName Tokens are created by strategies that are called from services, so it is *potentially* a breaking change.
|
@nnixaa it must be ok now. Please let me know if you agree with creating a NbAuthOAuth2JWTToken so that we have something symetric in token.ts and we can use in priority the payload 'iat' for createdAt and directly 'exp' for returning expiresAt. best regards Alain |
nnixaa
approved these changes
Jul 23, 2018
|
Hey @alain-charles, let's probably start with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token now contains ownerStrategyName, which is a back link to the strategy
used to create the token (future use).
BREAKING CHANGE :
NbAuthCreateToken (token.ts) now takes a third parameter, which is the ownerStrategyName
Tokens are created by strategies that are called from services, so it is potentially a breaking change.