Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: input directive #569

Merged
merged 18 commits into from
Jul 25, 2018
Merged

feat: input directive #569

merged 18 commits into from
Jul 25, 2018

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jul 19, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Add input directive

@yggg yggg added the WIP label Jul 19, 2018
@yggg yggg removed the WIP label Jul 19, 2018
@yggg yggg requested a review from nnixaa July 19, 2018 16:24
Copy link
Collaborator

@nnixaa nnixaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, let's add a block input that fils the whole width

{
type: 'tabs',
name: 'Input',
icon: '',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ask for an icon)

* ```
*
* Default input size is `medium`:
* @stacked-example(Showcase, input/input-showcase.component)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add placeholders into examples

@yggg yggg added the WIP label Jul 20, 2018
nnixaa
nnixaa previously approved these changes Jul 20, 2018
@nnixaa nnixaa merged commit 42c588e into akveo:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants