feat: lists #530
Merged
feat: lists #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnixaa
requested changes
Jul 5, 2018
| 'nbscroll', | ||
| { detail: { originalEvent: $event, ...this.getScrollInfo() } }, | ||
| ); | ||
| this.document.dispatchEvent(event); |
There was a problem hiding this comment.
should we run it outside of zone?
| * `nb-list-item` accepts arbitrary content, so you can create list of any components. | ||
| * | ||
| * List of users: | ||
| * @stacked-example(Users list, list/users-list-showcase.component) |
nnixaa
requested changes
Jul 9, 2018
| @@ -73,6 +73,13 @@ export class NbCardFooterComponent { | |||
| * Card with header and footer: | |||
| * @stacked-example(With Header & Footer, card/card-full.component) | |||
| * | |||
| * Most of the time main card content goes to `nb-card-body`, so it styled and aligned according to header and footer. | |||
There was a problem hiding this comment.
so it is styled and aligned according_ly_ to header and footer
| @@ -73,6 +73,13 @@ export class NbCardFooterComponent { | |||
| * Card with header and footer: | |||
| * @stacked-example(With Header & Footer, card/card-full.component) | |||
| * | |||
| * Most of the time main card content goes to `nb-card-body`, so it styled and aligned according to header and footer. | |||
| * But in case you need a higher level of control, you can pass contend directly to `nb-card`, | |||
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
=========================================
+ Coverage 69.72% 70.5% +0.77%
=========================================
Files 120 124 +4
Lines 3465 3590 +125
Branches 247 260 +13
=========================================
+ Hits 2416 2531 +115
- Misses 1003 1010 +7
- Partials 46 49 +3
|
nnixaa
requested changes
Jul 31, 2018
src/playground/playground.module.ts
Outdated
| @@ -348,6 +365,7 @@ export const NB_EXAMPLE_COMPONENTS = [ | |||
| NbPlaygroundBaseComponent, | |||
| ...NB_EXAMPLE_COMPONENTS, | |||
| ], | |||
| providers: [ NewsService ], | |||
There was a problem hiding this comment.
should we move it on a component level?
| @@ -73,6 +73,13 @@ export class NbCardFooterComponent { | |||
| * Card with header and footer: | |||
| * @stacked-example(With Header & Footer, card/card-full.component) | |||
| * | |||
| * Most of the time main card content goes to `nb-card-body`, so it styled and aligned accordingly to header and footer. | |||
There was a problem hiding this comment.
so it is styled and aligned in accordance with the header and footer.
| private getContainerDimentions(): Observable<NbScrollableContainerDimentions> { | ||
| if (this.elementScroll) { | ||
| const { scrollTop, scrollHeight, clientHeight } = this.elementRef.nativeElement; | ||
| return of({ scrollTop, scrollHeight, clientHeight }); |
| ) { | ||
| if (isPlatformBrowser(this.platformId) && this.window.history.scrollRestoration) { | ||
| this.initialScrollRestoration = window.history.scrollRestoration; | ||
| history.scrollRestoration = 'manual'; |
There was a problem hiding this comment.
we should add a not about this
| } | ||
|
|
||
| updateUrl(page) { | ||
| const queryParams = { ...this.route.snapshot.queryParams, page }; |
There was a problem hiding this comment.
we might not need to merge it here as navigate can do this internally https://angular.io/api/router/NavigationExtras#queryParamsHandling
| } | ||
|
|
||
| [class$="placeholder"] { | ||
| background: #f1f2f3; |
nnixaa
previously approved these changes
Aug 1, 2018
nnixaa
approved these changes
Aug 1, 2018
|
@yggg 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
List and infinite list components