Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add progress-bar component #459

Merged
merged 144 commits into from
Jun 7, 2018

Conversation

SashaSkywalker
Copy link
Member

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Progress bar component

Copy link
Collaborator

@nnixaa nnixaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of changes, otherwise looks great!

DEV_DOCS.md Outdated

- tests
````
src/framework/theme/components/your-component/your-component.spec.ts if you want basic rendering
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want basic rendering - > if you want to test basic rendering

DEV_DOCS.md Outdated
- register your component in docs
````
src/playground/your-component/your-component-showcase.component.ts (create example usage of your component)
src/playground/your-component/your-component-showcase.component.html (most probably looks like <nb-your-component></nb-your-component>)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add it to structure.ts

DEV_DOCS.md Outdated
src/playground/playground.module.ts (register your component in module)
src/playground/playground-routing.module.ts (routing)

your-component.component.ts (add line in docs section- * @example(Your component, your-component/your-component-showcase.component)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example -> stacked-example

.progress-container {
height: nb-theme(progress-bar-height);
border-radius: nb-theme(progress-bar-radius);
background-color: nb-theme(progress-bar-bg-color);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

progress-bar-bg-color -> rogress-bar-bg

background-color: nb-theme(progress-bar-primary-bg-color);
}
&.info {
background-color: nb-theme(progress-bar-info-bg-color);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no color after bg

* Licensed under the MIT License. See License.txt in the project root for license information.
*/

import {Component, Input} from '@angular/core';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces inside { }

* Progress bar accepts property `value` in range 0-100
* @stacked-example(Progress bar, progress-bar/progress-bar-showcase.component)
*
* Progress bar background configured by providing a `status` property:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..could be configured by..

* Progress bar background configured by providing a `status` property:
* @stacked-example(Progress bar status, progress-bar/progress-bar-status.component)
*
* Progress bar size (height and font-size) configured by providing a `size` property:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..could be configured by..

* Progress bar size (height and font-size) configured by providing a `size` property:
* @stacked-example(Progress bar size, progress-bar/progress-bar-size.component)
*
* `displayValue` property shows current value inside progress bar. It's also possible to add custom text inside tag:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for tag

@Component({
selector: 'nb-progress-bar',
template: `
<div class="progress-container {{size ? '' + size : ''}}">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces inside { }

tibing-old-email and others added 29 commits May 31, 2018 15:27
@nnixaa nnixaa changed the base branch from feat/new-design to master June 7, 2018 08:41
@nnixaa nnixaa merged commit 3693494 into akveo:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants