Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context-menu): hide on menu item click #431

Merged
merged 4 commits into from
May 21, 2018

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented May 19, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

fix #429 #423

@Tibing Tibing requested a review from nnixaa May 19, 2018 10:04

private subscribeOnItemClick() {
this.menuService.onItemClick()
.pipe(filter(({tag}) => tag === this.menuTag))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

takeWhilte(() => this.live)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@nnixaa nnixaa merged commit a5bcd3c into akveo:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbContextMenu
2 participants