Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hidden property #31

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Support hidden property #31

merged 1 commit into from
Oct 13, 2017

Conversation

Xstoudi
Copy link
Contributor

@Xstoudi Xstoudi commented Oct 13, 2017

Fix #30

@lexzhukov lexzhukov merged commit f26922a into akveo:master Oct 13, 2017
@lexzhukov
Copy link
Contributor

@Xstoudi thanks

@Mr-Sloth
Copy link

I have done the changes manually in my ngx-admin project but its strangly not working. Do I have to do something different for ngx ?

@nnixaa
Copy link
Collaborator

nnixaa commented Oct 16, 2017

Hey @darklinki, could you provide more details?

@Mr-Sloth
Copy link

@nnixaa

Sure,
I changed under node_modules/@nebular/theme/components/menu/menu-item.component.html
exactly like #30

Cleared npm cache and run the project with some menu items changed to hidden: true

The menu items are still shown.

@nnixaa
Copy link
Collaborator

nnixaa commented Oct 16, 2017

@darklinki the html file you are changing isn't being used in the built version of the module. So the only option to make this change in your local installation is to checkout Nebular separately and connect it to your project with npm link till this change is published in the new version.

@Mr-Sloth
Copy link

@nnixaa
Ty will try it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants