Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): ability to provide template as chat title #2920

Merged
merged 8 commits into from
Nov 17, 2021
Merged

feat(chat): ability to provide template as chat title #2920

merged 8 commits into from
Nov 17, 2021

Conversation

katebatura
Copy link
Contributor

@katebatura katebatura commented Oct 31, 2021 •
edited
Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

  • add nbChatTitle directive

How to use:

 <nb-chat>
   <ng-template nbChatTitle>
     //Your custom template for title
   </ng-template>
 </nb-chat>

@katebatura katebatura requested a review from yggg October 31, 2021 10:14
@katebatura katebatura self-assigned this Oct 31, 2021
@yggg yggg changed the title feat(chat): provide custom template to title feat(chat): template as chat title Oct 31, 2021
yggg
yggg suggested changes Nov 3, 2021
View reviewed changes
src/framework/theme/components/chat/chat.component.ts Outdated Show resolved Hide resolved
src/framework/theme/components/chat/chat.component.ts Outdated Show resolved Hide resolved
src/framework/theme/components/chat/chat.component.ts Outdated Show resolved Hide resolved
src/framework/theme/components/chat/chat.component.ts Outdated Show resolved Hide resolved
src/framework/theme/components/chat/chat.component.ts Outdated Show resolved Hide resolved
yggg
yggg suggested changes Nov 5, 2021
View reviewed changes
schematics/dist/utils/playground.js.map Outdated Show resolved Hide resolved
src/framework/theme/components/chat/chat-title.directive.spec.ts Outdated Show resolved Hide resolved
src/framework/theme/components/chat/chat.component.ts Outdated Show resolved Hide resolved
@katebatura katebatura requested a review from yggg November 9, 2021 12:35
@katebatura katebatura changed the base branch from master to 3.6.2 November 9, 2021 15:21
@katebatura katebatura changed the base branch from 3.6.2 to master November 9, 2021 15:21
@yggg yggg added this to the 9.0.0 milestone Nov 12, 2021
@yggg yggg force-pushed the feat/2919-nb-chat_template_in_title branch from 01345be to 9d1cef2 Compare November 16, 2021 15:07
@yggg yggg changed the title feat(chat): template as chat title feat(chat): ability to provide template as chat title Nov 17, 2021
@yggg yggg merged commit 9ccec64 into akveo:master Nov 17, 2021
This was referenced Nov 22, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yggg yggg yggg approved these changes

Assignees

@katebatura katebatura

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@katebatura @yggg