Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router tabset): ability to configure routerLinkActiveOptions per tab #2907

Merged
merged 6 commits into from
Dec 1, 2021

Conversation

sashaqred
Copy link
Member

@sashaqred sashaqred commented Oct 26, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Adds ability to configure routerLinkActiveOptions for individual tab. Config is merged with route tabset common config.
Also, adds NbRouteTab interface.

BREAKING CHANGE:
NbRouteTabsetComponent.tabs property type changed from any to NbRouteTab.
NbRouteTabsetComponent.changeTab property type changed from EventEmitter<any> to EventEmitter<NbRouteTab>.
tab parameter type of the NbRouteTabsetComponent.selectTab method changed from any to NbRouteTab.

@sashaqred sashaqred requested a review from yggg October 26, 2021 19:07
@yggg yggg added this to the 9.0.0 milestone Nov 12, 2021
@yggg yggg changed the title feat: add routerLinkActiveOptions to each tab feat(router tabset): ability to configure routerLinkActiveOptions per tab Dec 1, 2021
@yggg yggg merged commit 276d610 into master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants