Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): ability to add additional request headers #2825

Merged
merged 20 commits into from
Nov 16, 2021

Conversation

evtkhvch
Copy link
Contributor

@evtkhvch evtkhvch commented Aug 10, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1232

add headers?: HttpHeaders | { [header: string]: string | string[]; }; field to NbAuthStrategyOptions

BREAKING CHANGE:
NbOAuth2AuthStrategy.buildAuthHeader return type changed from any to HttpHeaders | undefined. If the method is overridden in a derived class, update its return type as well.

@evtkhvch evtkhvch requested a review from yggg November 12, 2021 15:02
@yggg yggg added this to the 9.0.0 milestone Nov 12, 2021
@evtkhvch evtkhvch requested a review from yggg November 15, 2021 11:53
@yggg yggg changed the title feat(auth): add headers to auth strategy options feat(auth): ability to add additional request headers Nov 16, 2021
@yggg yggg merged commit 3959848 into akveo:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable request headers for auth strategies
2 participants