Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toastr): add onclick, onclose events #2821

Merged
merged 7 commits into from
Nov 8, 2021
Merged

feat(toastr): add onclick, onclose events #2821

merged 7 commits into from
Nov 8, 2021

Conversation

evtkhvch
Copy link
Contributor

@evtkhvch evtkhvch commented Aug 6, 2021 •
edited by yggg
Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2595

  • add onClose method to NbToastRef that emit Observable<void>
  • add onClick method to NbToastRef that emit Observable<void>

@evtkhvch evtkhvch marked this pull request as ready for review August 9, 2021 07:45
@evtkhvch evtkhvch changed the title feat(toastr): onclick observable event feat(toastr): add onclick & onclose observable events Aug 9, 2021
@yggg yggg added this to the 9.0.0 milestone Sep 14, 2021
@yggg yggg changed the title feat(toastr): add onclick & onclose observable events feat(toastr): add onclick, onclose events Nov 8, 2021
@yggg yggg self-requested a review November 8, 2021 15:36
@yggg yggg removed this from the 9.0.0 milestone Nov 8, 2021
@yggg yggg merged commit 3795905 into akveo:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yggg yggg yggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast Ref OnClose, OnClick
2 participants
@evtkhvch @yggg