Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip, popover, context menu): correct physical positions in RTL #2819

Merged
merged 27 commits into from
Nov 25, 2021
Merged

fix(tooltip, popover, context menu): correct physical positions in RTL #2819

merged 27 commits into from
Nov 25, 2021

Conversation

evtkhvch
Copy link
Contributor

@evtkhvch evtkhvch commented Aug 5, 2021 •
edited by yggg
Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1884

Fix tooltip position issue when the direction set to RTL

Screenshot 2021-08-05 at 17 04 18

Screenshot 2021-08-05 at 17 04 07

Changes

  • add NbFlexibleConnectedPositionStrategy.direction

BREAKING CHANGE:
New directionService: NbLayoutDirectionService parameter in the NbDynamicOverlayChange constructor.

@yggg yggg added this to the 9.0.0 milestone Nov 12, 2021
@evtkhvch evtkhvch requested a review from yggg November 16, 2021 15:52
yggg
yggg suggested changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add list of breaking changes to the PR description

src/framework/theme/components/cdk/overlay/dynamic/dynamic-overlay-handler.ts Outdated Show resolved Hide resolved
src/framework/theme/components/cdk/overlay/mapping.ts Outdated Show resolved Hide resolved
src/framework/theme/components/cdk/overlay/overlay-position.ts Outdated Show resolved Hide resolved
src/framework/theme/components/cdk/overlay/position-helper.ts Outdated Show resolved Hide resolved
src/framework/theme/components/cdk/overlay/position-helper.ts Outdated Show resolved Hide resolved
@evtkhvch evtkhvch requested a review from yggg November 25, 2021 08:49
@yggg yggg changed the title fix(tooltip): rtl overlay position fix(tooltip): correct physical positions in RTL Nov 25, 2021
@yggg yggg changed the title fix(tooltip): correct physical positions in RTL fix(tooltip, popover, context menu): correct physical positions in RTL Nov 25, 2021
@yggg yggg merged commit 0959935 into akveo:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yggg yggg yggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[Tooltip]: Misplaced when direction is RTL
2 participants
@evtkhvch @yggg