feat: update to Angular 12 #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `_viewRepeater`, `_coalescedStyleScheduler` parameters of `NbTable` and `NbTreeGridComponent` constructors are now required. New parameters (`_viewportRuler`, `_stickyPositioningListener`) added to `NbTable` and `NbTreeGridComponent` constructors.
As now TypeScript requires argument for the resolve function. https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html#resolves-parameters-are-no-longer-optional-in-promises
As now TypeScript requires argument for the resolve function. https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html#resolves-parameters-are-no-longer-optional-in-promises
BREAKING CHANGE: Required version of `tslib` is `2.1.0`+
`@angular-devkit/*` packages have a different of rxjs and it causes incompatibilities in types. Switching to promises so we don't mix devkit Observables with operators from our version.
Angular 12 started to process `scss` files from the `assets` directory as a project files when building with production configuration. To prevent build errors we ignore `assets/examples` directory in the production configuration and than copying it manually to the dist directory when build is over. This way we prevent build error, but now we can't run `ng serve docs` with production configuration as we can't copy add examples directory to the internal Angular server. As a workaround we could build docs and then serve it with a simple http server, for example `npx http-server docs/dist` and navigate to `localhost:8080/nebular`. As for now it's still possible to run `ng serve docs` in a dev configuration. Details on assets processing: https://stackoverflow.com/a/67742437/9334725
Otherwise build produce error similar to `angular/angular-cli#20804` and `angular/angular-cli#20760`
|
any update on this |
andreipadolin
previously approved these changes
Jun 21, 2021
|
When the package will be updated? This should be considered urgent! |
|
any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Fixes #2763. Fixes #2742.
BREAKING CHANGE:
tslibversion is2.1.0.NbTableandNbTreeGridComponent:_viewRepeater,_coalescedStyleSchedulerconstructor parameters are now required._viewportRuler,_stickyPositioningListener) added to the constructor.