Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route tabset): add support for NavigationExtras options #2753

Merged
merged 3 commits into from
Jun 16, 2021
Merged

feat(route tabset): add support for NavigationExtras options #2753

merged 3 commits into from
Jun 16, 2021

Conversation

andreipadolin
Copy link
Contributor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes #2749

@andreipadolin andreipadolin requested a review from yggg May 27, 2021 11:38
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #2753 (62c0330) into master (002adc2) will decrease coverage by 6.69%.
The diff coverage is 75.51%.

❗ Current head 62c0330 differs from pull request most recent head eb7f51d. Consider uploading reports for the commit eb7f51d to get more accurate results

@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
- Coverage   84.57%   77.88%   -6.70%     
==========================================
  Files         235      262      +27     
  Lines        8059     8229     +170     
  Branches      710      896     +186     
==========================================
- Hits         6816     6409     -407     
- Misses       1023     1544     +521     
- Partials      220      276      +56     
Impacted Files Coverage Δ
src/framework/auth/components/auth.component.ts 28.57% <0.00%> (-15.88%) ⬇️
...framework/auth/strategies/auth-strategy-options.ts 100.00% <ø> (ø)
.../auth/strategies/oauth2/oauth2-strategy.options.ts 100.00% <ø> (ø)
...ramework/auth/strategies/oauth2/oauth2-strategy.ts 83.57% <ø> (-1.10%) ⬇️
...work/auth/strategies/password/password-strategy.ts 97.59% <ø> (-0.24%) ⬇️
...ponents/accordion/accordion-item-body.component.ts 46.15% <0.00%> (-12.67%) ⬇️
...nents/accordion/accordion-item-header.component.ts 40.00% <0.00%> (-8.28%) ⬇️
...e/components/accordion/accordion-item.component.ts 28.57% <0.00%> (-9.73%) ⬇️
.../theme/components/accordion/accordion.component.ts 41.66% <ø> (-11.67%) ⬇️
...eme/components/calendar-kit/calendar-kit.module.ts 100.00% <ø> (ø)
... and 322 more

@Cvele85
Copy link

Cvele85 commented Jun 10, 2021

Is this now regulated or not !?

@andreipadolin
Copy link
Contributor Author

andreipadolin commented Jun 10, 2021

Hi @Cvele85 currently not, but will be available within next release.

@yggg yggg changed the title feat(route-tabset): added support for NavigationExtras options feat(route tabset): add support for NavigationExtras options Jun 16, 2021
@yggg yggg merged commit bcf7b65 into akveo:master Jun 16, 2021
@Cvele85
Copy link

Cvele85 commented Jun 16, 2021

How is this supposed to work now?

If I have it set that way:
this.tabs = [
{
title: this.translate.instant("pages.general.tabs.details"),
responsive: false,
route: [/job-titles/${params.id}],
queryParams: {returnUrl: this.returnUrl},
icon: 'list-outline',
},
];

Then the link must be like this:
http:https://localhost:4200/job-titles/0Q6Xyu?returnUrl=%2Fjob-titles

When will this be released?

When it's released then I have to go to 'package.json', probably change the version is so !?
"@nebular/theme": "7.0.0-beta.2",

@Cvele85
Copy link

Cvele85 commented Jun 29, 2021

Hi @Cvele85 currently not, but will be available within next release.

How is this supposed to work now?

If I have it set that way:
this.tabs = [
{
title: this.translate.instant("pages.general.tabs.details"),
responsive: false,
route: [/job-titles/${params.id}],
queryParams: {returnUrl: this.returnUrl},
icon: 'list-outline',
},
];

Then the link must be like this:
http:https://localhost:4200/job-titles/0Q6Xyu?returnUrl=%2Fjob-titles

When will this be released?

When it's released then I have to go to 'package.json', probably change the version is so !?
"@nebular/theme": "7.0.0-beta.2",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nb-route-tabset -> route - how to add queryParams
3 participants