Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scroll dispatcher): emit scroll events from cdkScrollable directive #2714

Merged
merged 3 commits into from
May 14, 2021
Merged

fix(scroll dispatcher): emit scroll events from cdkScrollable directive #2714

merged 3 commits into from
May 14, 2021

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 14, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #2714 (1a15996) into master (db9e556) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2714      +/-   ##
==========================================
+ Coverage   77.82%   77.91%   +0.09%     
==========================================
  Files         262      262              
  Lines        8229     8229              
  Branches      896      896              
==========================================
+ Hits         6404     6412       +8     
+ Misses       1550     1540      -10     
- Partials      275      277       +2     
Impacted Files Coverage Δ
...omponents/cdk/adapter/scroll-dispatcher-adapter.ts 100.00% <100.00%> (ø)
...mework/theme/components/sidebar/sidebar.service.ts 90.62% <100.00%> (+18.75%) ⬆️
...work/theme/components/sidebar/sidebar.component.ts 77.33% <0.00%> (+1.33%) ⬆️

@yggg yggg merged commit f715e97 into akveo:master May 14, 2021
@yggg yggg deleted the fix/scroll-dispatcher-adapter-cdk-scrollable branch May 14, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant