Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toastr): remove deprecated iconPack property #2620

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Dec 16, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGE:
NbToastrConfig.iconPack property remove. You can set icon pack via icon property:

const toastrConfig = {
  // ...
  icon: { icon: 'star', pack: 'eva' },
}

NbToastComponent.iconPack and NbToastComponent.iconConfig properties removed.
Use icon property instead.

BREAKING CHANGE:
`NbToastrConfig.iconPack` property remove. You can set icon pack via `icon` property:
```
const toastrConfig = {
  // ...
  icon: { icon: 'star', pack: 'eva' },
}
```

`NbToastComponent.iconPack` and `NbToastComponent.iconConfig` properties removed.
Use `icon` property instead.
@yggg yggg merged commit 77a3519 into master Dec 16, 2020
@yggg yggg deleted the feat/toastr-remove-deprecated-icon-pack-property branch December 16, 2020 20:11
yggg added a commit that referenced this pull request Dec 24, 2020
BREAKING CHANGE:
`NbToastrConfig.iconPack` property removed. You can set icon pack via `icon` property:
```
const toastrConfig = {
  // ...
  icon: { icon: 'star', pack: 'eva' },
}
```

`NbToastComponent.iconPack` and `NbToastComponent.iconConfig` properties removed.
Use `icon` property instead.

(cherry picked from commit 77a3519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant