Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add custom comparator input #2590

Merged
merged 11 commits into from
Dec 16, 2020

Conversation

ascripcaru
Copy link
Contributor

@ascripcaru ascripcaru commented Nov 10, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Select options only worked when using primitives as values. If you had to use objects the === could not cope with the complex values. Thus, I added the possibility to add a custom compare function as a parameter for nebular select for more complex use cases and kept the old functionality in place.

Closes #2543. Closes #1223. Closes #1858.

@ascripcaru
Copy link
Contributor Author

fixes issue #2543

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #2590 (8bf8838) into master (09a7ba1) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #2590      +/-   ##
==========================================
- Coverage   78.95%   78.94%   -0.01%     
==========================================
  Files         253      253              
  Lines        7815     7819       +4     
  Branches      857      857              
==========================================
+ Hits         6170     6173       +3     
- Misses       1382     1383       +1     
  Partials      263      263              
Impacted Files Coverage Δ
...mework/theme/components/select/select.component.ts 88.46% <85.71%> (-0.20%) ⬇️
...endar-kit/services/calendar-month-model.service.ts 98.03% <0.00%> (ø)

@ghost
Copy link

ghost commented Nov 10, 2020

DeepCode's analysis on #a58e55 found:

  • ℹ️ 1 minor issue. 👇

Top issues

Description Example fixes
Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@ascripcaru
Copy link
Contributor Author

hello @yggg. is there any chance for this functionality to be added in a next release of nebular?

@yggg yggg changed the title Add custom compare function for object like options feat(select): add custom comparator input Dec 16, 2020
Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ascripcaru!

@yggg yggg merged commit 1f8a57b into akveo:master Dec 16, 2020
yggg pushed a commit that referenced this pull request Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants