Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select, autocomplete): ability to change scroll strategy #2567

Merged
merged 3 commits into from
Dec 18, 2020

Conversation

sashaqred
Copy link
Member

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Update autocomplete scroll strategy

@sashaqred sashaqred requested a review from yggg October 23, 2020 20:27
@sashaqred sashaqred self-assigned this Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #2567 (895ee4e) into master (c1aafb9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2567   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files         258      258           
  Lines        7964     7964           
  Branches      872      872           
=======================================
  Hits         6299     6299           
  Misses       1391     1391           
  Partials      274      274           
Impacted Files Coverage Δ
.../components/autocomplete/autocomplete.directive.ts 82.91% <100.00%> (ø)

yggg
yggg previously approved these changes Oct 27, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

DeepCode's analysis on #1966f7 found:

  • ℹ️ 1 minor issue. 👇

Top issues

Description Example fixes
asterisks in jsdoc must be aligned Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@yggg yggg changed the title fix: update autocomplete scroll strategy feat(select, autocomplete): add ability to change scroll strategy Dec 18, 2020
@yggg yggg changed the title feat(select, autocomplete): add ability to change scroll strategy feat(select, autocomplete): ability to change scroll strategy Dec 18, 2020
@yggg yggg merged commit d10275b into master Dec 18, 2020
@yggg yggg deleted the fix/update-autocomplete-scroll-strategy branch December 18, 2020 15:26
yggg pushed a commit that referenced this pull request Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants