Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): update input element disabled state #2555

Merged
merged 8 commits into from
Oct 21, 2020

Conversation

sashaqred
Copy link
Member

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2371

Add support of disabled to autocomplete

@sashaqred sashaqred requested a review from yggg October 15, 2020 09:03
@sashaqred sashaqred self-assigned this Oct 15, 2020
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #2555 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #2555   +/-   ##
=======================================
  Coverage   78.94%   78.95%           
=======================================
  Files         253      253           
  Lines        7809     7815    +6     
  Branches      855      857    +2     
=======================================
+ Hits         6165     6170    +5     
- Misses       1380     1382    +2     
+ Partials      264      263    -1     
Impacted Files Coverage Δ
.../components/autocomplete/autocomplete.directive.ts 81.36% <50.00%> (+0.07%) ⬆️

@sashaqred sashaqred requested a review from yggg October 19, 2020 19:50
@yggg yggg changed the title feat: add disable on autocomplete fix(autocomplete): control input disabled state Oct 21, 2020
@yggg yggg changed the title fix(autocomplete): control input disabled state fix(autocomplete): update input element disabled state Oct 21, 2020
@yggg yggg merged commit 23e59ba into master Oct 21, 2020
@yggg yggg deleted the feat/add-disable-on-autocomplete branch October 21, 2020 15:11
@yggg yggg linked an issue Jan 6, 2021 that may be closed by this pull request
2 tasks
yggg pushed a commit that referenced this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants