Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion): extract inner elements styles outside accordion #2536

Merged
merged 2 commits into from
Sep 30, 2020
Merged

fix(accordion): extract inner elements styles outside accordion #2536

merged 2 commits into from
Sep 30, 2020

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Sep 30, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

This way nb-accordion inner items (like nb-accordion-item-header, nb-accordion-item, nb-accordion-item-body) keep their styles when are placed outside nb-accordion element (for example, when used as cdkDrag as when element dragged it placed in the body).

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #2536 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2536   +/-   ##
=======================================
  Coverage   78.93%   78.93%           
=======================================
  Files         253      253           
  Lines        7808     7808           
  Branches      855      855           
=======================================
  Hits         6163     6163           
  Misses       1380     1380           
  Partials      265      265           
Impacted Files Coverage Δ
...k/theme/components/datepicker/datepicker.module.ts 100.00% <ø> (ø)
...heme/components/timepicker/timepicker.directive.ts 22.95% <ø> (ø)
...k/theme/components/timepicker/timepicker.module.ts 50.00% <ø> (ø)

@yggg yggg changed the title fix(accordion): extract inner elements styles outside accordion selector fix(accordion): extract inner elements styles outside accordion Sep 30, 2020
@yggg yggg merged commit 9089690 into akveo:master Sep 30, 2020
@yggg yggg deleted the fix/accordion-move-inner-elements-style-outside-accordion branch September 30, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant