Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): add value reset with undefined #2511

Merged
merged 5 commits into from
Sep 17, 2020

Conversation

sashaqred
Copy link
Member

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Remove undefined-value checks before running of change detection, because these checks break the possibility to reset value with passing undefined

@sashaqred sashaqred added the bug label Sep 14, 2020
@sashaqred sashaqred requested a review from yggg September 14, 2020 16:37
@sashaqred sashaqred self-assigned this Sep 14, 2020
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #2511 into master will decrease coverage by 1.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2511      +/-   ##
==========================================
- Coverage   80.46%   78.97%   -1.49%     
==========================================
  Files         244      253       +9     
  Lines        7172     7772     +600     
  Branches      785      851      +66     
==========================================
+ Hits         5771     6138     +367     
- Misses       1168     1371     +203     
- Partials      233      263      +30     
Impacted Files Coverage Δ
...ramework/auth/strategies/oauth2/oauth2-strategy.ts 83.57% <ø> (ø)
...amework/date-fns/services/date-fns-date.service.ts 68.75% <ø> (-4.59%) ⬇️
...c/framework/moment/services/moment-date.service.ts 88.11% <ø> (-1.89%) ⬇️
...work/theme/components/actions/actions.component.ts 96.77% <ø> (-3.23%) ⬇️
...ramework/theme/components/badge/badge.component.ts 93.47% <ø> (+0.79%) ⬆️
...eme/components/calendar-kit/calendar-kit.module.ts 100.00% <ø> (ø)
...nts/calendar-actions/calendar-actions.component.ts 75.00% <ø> (ø)
...framework/theme/components/calendar-kit/helpers.ts 92.85% <ø> (-7.15%) ⬇️
...lendar-kit/services/calendar-time-model.service.ts 55.17% <ø> (ø)
...e/components/calendar-kit/services/date.service.ts 83.87% <ø> (-8.44%) ⬇️
... and 58 more

@sashaqred sashaqred requested a review from yggg September 16, 2020 12:13
@yggg yggg merged commit 9ac12c7 into master Sep 17, 2020
@yggg yggg deleted the fix/add-value-reset-with-undefined branch September 17, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants