Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): add client_id to the refresh request #2350

Merged
merged 3 commits into from
Sep 17, 2020

Conversation

alain-charles
Copy link
Contributor

According to RFC4749, client_id has to be present in the body of token request with refresh_token grant_type and no client auth.

Verified on Keyclock 4.X - Invalid_credentials error if client_id is not passed, even if client is not confidential (i.e. without client-secret)

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #2350 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2350   +/-   ##
=======================================
  Coverage   78.94%   78.94%           
=======================================
  Files         253      253           
  Lines        7770     7770           
  Branches      852      852           
=======================================
  Hits         6134     6134           
  Misses       1371     1371           
  Partials      265      265           
Impacted Files Coverage Δ
...ramework/auth/strategies/oauth2/oauth2-strategy.ts 83.57% <ø> (ø)

@alain-charles
Copy link
Contributor Author

Hi @nnixaa
Can you please have a look at this pull request and tell me what you think about it ?
Regards
Alain

@yggg yggg changed the title NbOAuth2Strategy : fix fissing client_id in refres_token request body with NO AUTH fix(auth): add client_id to the refresh request Sep 17, 2020
Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alain-charles!

@yggg yggg merged commit 10b01fa into akveo:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants