feat: update to Angular 9 #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'undefined' breaks injection in Angular 9
Required by Ivy if component is used in module imports
Required by Angular 9
Already set at the options
Styles loading was broken as now styles emitting as ES module. Install a newer version of style-loader which is capable to handle ESM. Style loader package could be uninstalled once Angular CLI updates own version.
get method is deprecated
Something changed in a way CDK is listening to keydown event so dispatch event stopped working. Override NbOverlayService and add manual trigger method to have reliable method to emulate keydown event.
Angular 9 throws an error when calling detect changes during component creation. It happens with radio component when it has no name and radio group set name in after content init hook because radio had detect changes call. Refactor radio to not call change detection methods from input setters and add `_markForCheck` and `_setName` methods to trigger it manually from the radio group component.
writeValue had detectChanges call and I think it probably could be called during creation mode. If so, error would be thrown. Calling markForCheck is safe.
To prevent helpers inlining
yggg
force-pushed
the
feat/update-to-angular-9-stable
branch
from
784d8b9
to
6530f60
Compare
yggg
force-pushed
the
feat/update-to-angular-9-stable
branch
from
21c3576
to
0eb909b
Compare
yggg
force-pushed
the
feat/update-to-angular-9-stable
branch
from
322780f
to
1a54334
Compare
|
Eagerly waiting for this. Please do it soon. Thank you so much for such a wonderful library. |
Tibing
requested changes
Feb 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #2236 +/- ##
==========================================
+ Coverage 81.6% 81.64% +0.04%
==========================================
Files 244 244
Lines 7329 7329
Branches 771 771
==========================================
+ Hits 5981 5984 +3
+ Misses 1121 1117 -4
- Partials 227 228 +1
|
Tibing
previously approved these changes
Mar 2, 2020
tslib is now listed as a peer dependency rather than a direct dependency in Angular
Tibing
approved these changes
Mar 2, 2020
|
Cool. Thanks again @yggg . Is there gonna be a release soon? |
This was referenced Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves: