Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): use basic status instead deprecated empty string #2063

Merged
merged 3 commits into from
Nov 12, 2019

Conversation

smorcuend
Copy link
Contributor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

On Auth components with https://github.com/akveo/nebular/pull/2047/files# changes:
Warning message is triggered when nbInput component with status input attribute is an empty string.
On login component there is an occurrence with this issue. Replace empty string with basic value on status attribute.

@yggg yggg self-requested a review November 11, 2019 14:54
Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smorcuend! 👍

@yggg yggg changed the title Avoid warning message nbInput empty status fix(auth): use basic status instead deprecated empty string Nov 12, 2019
@yggg yggg merged commit a202468 into akveo:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants