Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle): animation for IE11 #2062

Merged
merged 8 commits into from
Nov 14, 2019

Conversation

denStrigo
Copy link
Collaborator

@denStrigo denStrigo commented Nov 4, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1976

@denStrigo denStrigo requested a review from yggg November 4, 2019 13:13
@denStrigo denStrigo self-assigned this Nov 4, 2019
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #2062 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2062      +/-   ##
==========================================
+ Coverage   84.57%   84.58%   +0.01%     
==========================================
  Files         235      235              
  Lines        8038     8037       -1     
  Branches      706      707       +1     
==========================================
  Hits         6798     6798              
  Misses       1020     1020              
+ Partials      220      219       -1
Impacted Files Coverage Δ
...mework/theme/components/toggle/toggle.component.ts 90.12% <100%> (+2.31%) ⬆️
src/framework/theme/services/direction.service.ts 91.3% <0%> (-4.35%) ⬇️

@yggg yggg changed the title fix(ToggleComponent): fix ToggleComponent animation fot IE11 fix(toggle): animation for IE11 Nov 14, 2019
@yggg yggg merged commit 1d52a20 into akveo:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbToggleComponent not supported in IE 11
2 participants