Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker, radio): always call touched callback #2026

Merged
merged 2 commits into from
Oct 22, 2019
Merged

fix(datepicker, radio): always call touched callback #2026

merged 2 commits into from
Oct 22, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Oct 18, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

We need to call touched callback on each blur event to run control update and validation as Angular Forms Api relies on it when configured to update on blur.

@yggg yggg requested a review from nnixaa October 18, 2019 14:04
@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #2026 into master will increase coverage by 0.01%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #2026      +/-   ##
==========================================
+ Coverage   84.23%   84.25%   +0.01%     
==========================================
  Files         235      235              
  Lines        7903     7899       -4     
  Branches      693      693              
==========================================
- Hits         6657     6655       -2     
+ Misses       1042     1040       -2     
  Partials      204      204
Impacted Files Coverage Δ
...heme/components/datepicker/datepicker.directive.ts 80.32% <50%> (ø) ⬆️
...rk/theme/components/radio/radio-group.component.ts 89.24% <66.66%> (+1.61%) ⬆️

@yggg yggg merged commit d3a8e44 into akveo:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants