Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): make sure icon has margins when button has html comments… #1953

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Sep 11, 2019

… inside

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #1953 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1953      +/-   ##
==========================================
+ Coverage   84.07%   84.09%   +0.01%     
==========================================
  Files         234      234              
  Lines        7726     7734       +8     
  Branches      680      680              
==========================================
+ Hits         6496     6504       +8     
  Misses       1032     1032              
  Partials      198      198
Impacted Files Coverage Δ
src/framework/theme/components/helpers.ts 77.77% <100%> (+17.77%) ⬆️
...mework/theme/components/button/button.component.ts 87.2% <100%> (ø) ⬆️
...endar-kit/services/calendar-month-model.service.ts 98.14% <0%> (ø) ⬆️

@nnixaa nnixaa merged commit a17accb into master Sep 11, 2019
@nnixaa nnixaa deleted the feat/button-icon-comment branch September 11, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants