Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): allow initial falsy values #1936

Merged
merged 3 commits into from
Aug 29, 2019
Merged

fix(select): allow initial falsy values #1936

merged 3 commits into from
Aug 29, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Aug 28, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@yggg yggg requested a review from nnixaa August 28, 2019 16:41
nnixaa
nnixaa previously approved these changes Aug 28, 2019
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #1936 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1936   +/-   ##
=======================================
  Coverage   84.08%   84.08%           
=======================================
  Files         234      234           
  Lines        7723     7723           
  Branches      679      679           
=======================================
  Hits         6494     6494           
  Misses       1031     1031           
  Partials      198      198
Impacted Files Coverage Δ
...mework/theme/components/select/select.component.ts 89.96% <100%> (ø) ⬆️

@yggg yggg merged commit 02080fb into akveo:master Aug 29, 2019
@yggg yggg deleted the fix/select-initial-falsy-value branch August 29, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants