Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabset): add tabid property #1919

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Conversation

hryb
Copy link
Contributor

@hryb hryb commented Aug 21, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

It resolves the situations when need to understand which tab was chosen with changeTab method. It can't be done with tabTitle property because the title can be translated during component initialization

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #1919 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1919      +/-   ##
==========================================
+ Coverage   84.09%   84.09%   +<.01%     
==========================================
  Files         234      234              
  Lines        7734     7735       +1     
  Branches      680      680              
==========================================
+ Hits         6504     6505       +1     
  Misses       1032     1032              
  Partials      198      198
Impacted Files Coverage Δ
...mework/theme/components/tabset/tabset.component.ts 92.15% <100%> (+0.15%) ⬆️

yggg
yggg previously approved these changes Sep 20, 2019
@yggg yggg merged commit d5bf53a into akveo:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants