Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamic overlay): recreate overlay when overlay container change #1913

Merged
merged 5 commits into from
Aug 21, 2019
Merged

fix(dynamic overlay): recreate overlay when overlay container change #1913

merged 5 commits into from
Aug 21, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Aug 19, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1136 and #1273

@yggg yggg requested a review from nnixaa August 19, 2019 12:15
@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #1913 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1913      +/-   ##
=========================================
+ Coverage   83.98%     84%   +0.02%     
=========================================
  Files         234     234              
  Lines        7675    7686      +11     
  Branches      672     673       +1     
=========================================
+ Hits         6446    6457      +11     
  Misses       1031    1031              
  Partials      198     198
Impacted Files Coverage Δ
...ork/theme/components/cdk/adapter/adapter.module.ts 100% <100%> (ø) ⬆️
.../components/cdk/overlay/dynamic/dynamic-overlay.ts 98.97% <100%> (+0.11%) ⬆️

@yggg yggg merged commit 258b75b into akveo:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context menu does not render after router navigation
2 participants