Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidebar): add the ability to determine state and responsiveState #1893

Merged
merged 13 commits into from
Dec 16, 2020
Merged

feat(sidebar): add the ability to determine state and responsiveState #1893

merged 13 commits into from
Dec 16, 2020

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Aug 8, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1241

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #1893 (a7f5ee9) into master (09a7ba1) will increase coverage by 5.03%.
The diff coverage is 55.76%.

@@            Coverage Diff             @@
##           master    #1893      +/-   ##
==========================================
+ Coverage   78.95%   83.98%   +5.03%     
==========================================
  Files         253      232      -21     
  Lines        7815     7593     -222     
  Branches      857      662     -195     
==========================================
+ Hits         6170     6377     +207     
+ Misses       1382     1020     -362     
+ Partials      263      196      -67     
Impacted Files Coverage Δ
...work/theme/components/sidebar/sidebar.component.ts 60.30% <54.54%> (+5.41%) ⬆️
...mework/theme/components/sidebar/sidebar.service.ts 72.00% <57.14%> (-14.37%) ⬇️
src/framework/theme/public_api.ts 100.00% <100.00%> (ø)
...eme/components/calendar/base-calendar.component.ts 76.59% <0.00%> (-19.90%) ⬇️
...amework/theme/components/toastr/toast.component.ts 60.71% <0.00%> (-17.07%) ⬇️
...me/components/toastr/toastr-container.component.ts 65.38% <0.00%> (-16.97%) ⬇️
...rk/theme/components/cdk/overlay/position-helper.ts 36.06% <0.00%> (-9.70%) ⬇️
...vigation/calendar-pageable-navigation.component.ts 92.30% <0.00%> (-7.70%) ⬇️
...ramework/theme/components/toastr/toastr.service.ts 90.51% <0.00%> (-6.88%) ⬇️
src/framework/theme/components/helpers.ts 60.00% <0.00%> (-6.67%) ⬇️
... and 243 more

@yggg yggg requested a review from nnixaa October 8, 2019 16:20
@yggg yggg marked this pull request as ready for review October 8, 2019 16:20
@yggg yggg added this to the 5.0.0 milestone Oct 8, 2019
@yggg yggg changed the title feat(sidebar): add get sidebar with method feat(sidebar): add get sidebar state method Oct 10, 2019
@yggg yggg modified the milestones: 5.0.0, 5.2.0, 6.0.0 Mar 13, 2020
@yggg yggg changed the title feat(sidebar): add get sidebar state method feat(sidebar): add the ability to get state and responsiveState Dec 16, 2020
@yggg yggg changed the title feat(sidebar): add the ability to get state and responsiveState feat(sidebar): add the ability to determine state and responsiveState Dec 16, 2020
@yggg yggg changed the title feat(sidebar): add the ability to determine state and responsiveState feat(sidebar): add the ability to determine state and responsiveState Dec 16, 2020
@yggg yggg merged commit bac0edc into akveo:master Dec 16, 2020
@yggg yggg deleted the fix/sidebar-state-change-event branch December 16, 2020 18:48
yggg added a commit that referenced this pull request Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbSidebarComponent State
1 participant