Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): stop listening for close events when dialog closes #1860

Merged
merged 2 commits into from
Jul 29, 2019
Merged

fix(dialog): stop listening for close events when dialog closes #1860

merged 2 commits into from
Jul 29, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jul 25, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1847

@yggg yggg requested a review from Tibing July 25, 2019 14:05
@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #1860 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1860   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         232      232           
  Lines        7595     7595           
  Branches      670      670           
=======================================
  Hits         6370     6370           
  Misses       1027     1027           
  Partials      198      198
Impacted Files Coverage Δ
...ramework/theme/components/dialog/dialog.service.ts 89.23% <100%> (ø) ⬆️

@yggg yggg requested review from nnixaa and removed request for Tibing July 29, 2019 13:12
@yggg yggg merged commit 7ddbfbd into akveo:master Jul 29, 2019
@yggg yggg deleted the fix/dialog-memory-leak branch July 29, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal/Dialog memory leak
2 participants