Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): scroll block in with scroll mode #1805

Merged
merged 8 commits into from
Jul 12, 2019
Merged

fix(layout): scroll block in with scroll mode #1805

merged 8 commits into from
Jul 12, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jul 11, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Prevents content from widening when scroll block enabled by adding padding equal to scroll bar width.

yggg added 4 commits July 11, 2019 15:01
Move outside of `nb-layout .layout` selector
Layout was taking up space which became available after hiding scrollbar
on the parent. Now we add padding equal to scroll width so content width
is persistent.
@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #1805 into master will decrease coverage by 0.03%.
The diff coverage is 62.85%.

@@            Coverage Diff             @@
##           master    #1805      +/-   ##
==========================================
- Coverage   83.91%   83.88%   -0.04%     
==========================================
  Files         232      232              
  Lines        7568     7595      +27     
  Branches      665      670       +5     
==========================================
+ Hits         6351     6371      +20     
- Misses       1023     1026       +3     
- Partials      194      198       +4
Impacted Files Coverage Δ
...mework/theme/components/layout/layout.component.ts 75% <62.85%> (-0.15%) ⬇️

@yggg yggg requested a review from nnixaa July 11, 2019 13:44
@yggg yggg merged commit 8958fc9 into akveo:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants