Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): include helpers into public api #1754

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jul 10, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1675

@yggg yggg requested a review from nnixaa July 10, 2019 12:03
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #1754 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
+ Coverage   83.91%   83.91%   +<.01%     
==========================================
  Files         232      232              
  Lines        7567     7568       +1     
  Branches      665      665              
==========================================
+ Hits         6350     6351       +1     
  Misses       1023     1023              
  Partials      194      194
Impacted Files Coverage Δ
src/framework/auth/public_api.ts 100% <100%> (ø) ⬆️

@yggg yggg requested a review from Tibing July 10, 2019 12:20
@yggg yggg removed the request for review from nnixaa July 10, 2019 12:21
@yggg yggg merged commit f6f301b into master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module not found: Error: Can't resolve '@nebular/auth/helpers'
2 participants