feat: angular package format #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type annotation on fields with forwardRef lead to 'Cannot access X before initialization' error in es2015 build. This change also fixes circular dependency warning.
Prevents "Maximum call stack size exceeded" when building with "flatModuleOutFile". angular#25226
Fixes "Cannot access NbLayoutComponent before initialization". When building with ES2015 target, "forwardRef" in header breaks. angular#30106.
angular#20931
angular#20931
angular#20931
They will be inserted during the build
Enables more aggressive webpack optimizations
…t/ng8-es2015-bundle
Codecov Report
@@ Coverage Diff @@
## master #1474 +/- ##
==========================================
+ Coverage 82.95% 83.29% +0.34%
==========================================
Files 240 230 -10
Lines 7332 7489 +157
Branches 659 659
==========================================
+ Hits 6082 6238 +156
- Misses 1060 1061 +1
Partials 190 190
|
Tibing
requested changes
May 22, 2019
scripts/ci/packages-smoke.sh
Outdated
| @@ -17,8 +17,10 @@ packages_smoke() { | |||
| cp -r ../nebular/src/.lib/* node_modules/@nebular | |||
|
|
|||
| echo "Verifying application build" | |||
| npm run build --prod --aot | |||
| npm run build -- --prod --aot | |||
There was a problem hiding this comment.
I'm pretty sure we don't need --aot flag here because it's already listed as aot: true in angular.json for production environment. Could you please, remove it?
DEV_DOCS.md
Outdated
| @@ -27,6 +27,7 @@ | |||
| - add the package into bump-version.ts which bumps package version and its dependencies | |||
| - add the package external dependencies into rollup-config.ts which gives rollup capability build package correctly | |||
| - add the package into bundle.ts which build umd modules for our packages | |||
| - add the package into `JS_PACKAGES` in config.ts which used to add es2015 bundles for our packages | |||
There was a problem hiding this comment.
Could you please mention where that config.ts lives? 😄
scripts/gulp/tasks/change-prefix.ts
Outdated
| @@ -6,7 +6,7 @@ import * as replace from 'gulp-replace'; | |||
| import * as minimist from 'minimist'; | |||
| import { capitalize, dasherize } from '@angular-devkit/core/src/utils/strings'; | |||
|
|
|||
| import { replaceScssWithCss } from './copy-sources'; | |||
| // import { replaceScssWithCss } from './copy-sources'; | |||
There was a problem hiding this comment.
I think that line has to be removed
Tibing
requested changes
May 22, 2019
scripts/gulp/tasks/change-prefix.ts
Outdated
| @@ -218,7 +218,7 @@ task('change-prefix', ['copy-build-dir-and-rename', 'generate-ts-config', 'patch | |||
|
|
|||
| return stream | |||
| .pipe(dest(BUILD_DIR)) | |||
| .on('end', replaceScssWithCss); | |||
| // .on('end', replaceScssWithCss); | |||
There was a problem hiding this comment.
I think that line has to be removed
Tibing
approved these changes
May 22, 2019
|
I personally like the implementation 😄 👍 |
|
LGTM |
|
Thanks 🙂 |
This was referenced May 22, 2019
Closed
yggg
added a commit
that referenced
this pull request
May 27, 2019
yggg
added a commit
that referenced
this pull request
Jun 5, 2019
yggg
added a commit
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Adds
esm2015,fesm2015,fesm5into packages distributives.BREAKING CHANGE:
Everything not mentioned in packages
public_api.tsnow private. Direct imports from (@nebular/theme/*) will stop working.