feat: remove fields scheduled to be removed in 4.0 #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Popover: 'nbPopoverMode' input removed. Use 'nbPopoverTrigger' instead. NbPopoverDirective 'mode' property removed. Use 'trigger' instead. NbSelectComponent 'selectionChange' removed. Use nb-select (selected) binding to track selection change and <nb-option (click)=""> to track option click.
Codecov Report
@@ Coverage Diff @@
## master #1439 +/- ##
==========================================
+ Coverage 82.57% 82.59% +0.02%
==========================================
Files 240 240
Lines 7327 7320 -7
Branches 656 656
==========================================
- Hits 6050 6046 -4
+ Misses 1088 1085 -3
Partials 189 189
|
yggg
added a commit
that referenced
this pull request
May 27, 2019
BREAKING CHANGE: Popover: 'nbPopoverMode' input removed. Use 'nbPopoverTrigger' instead. NbPopoverDirective 'mode' property removed. Use 'trigger' instead. NbSelectComponent 'selectionChange' removed. Use nb-select (selected) binding to track selection change and <nb-option (click)=""> to track option click.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves: