Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): prevent navigation to disabled option from keyboard #1427

Merged
merged 2 commits into from
Apr 26, 2019
Merged

fix(select): prevent navigation to disabled option from keyboard #1427

merged 2 commits into from
Apr 26, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 26, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #1427 into next will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next    #1427      +/-   ##
==========================================
- Coverage   82.57%   82.57%   -0.01%     
==========================================
  Files         240      240              
  Lines        7328     7327       -1     
  Branches      654      654              
==========================================
- Hits         6051     6050       -1     
  Misses       1088     1088              
  Partials      189      189
Impacted Files Coverage Δ
...mework/theme/components/select/option.component.ts 98.18% <100%> (-0.04%) ⬇️

@yggg yggg merged commit 850cbb9 into akveo:next Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant