Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu): Eva style #1421

Merged
merged 15 commits into from
Apr 25, 2019
Merged

feat(menu): Eva style #1421

merged 15 commits into from
Apr 25, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 25, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGE:

Removed inverse mode.

NbMenuComponent 'autoCollapseValue' property changed to 'autoCollapse'.

Following theme variables were removed:
menu-font-family -> menu-text-font-family
menu-font-size -> menu-text-font-size
menu-font-weight -> menu-text-font-weight
menu-fg -> menu-text-color
menu-bg -> menu-background-color
menu-active-fg -> menu-item-active-text-color
menu-active-bg -> menu-item-active-background-color
menu-submenu-bg -> menu-submenu-background-color
menu-submenu-fg -> menu-submenu-text-color
menu-submenu-active-fg -> menu-submenu-item-active-text-color
menu-submenu-active-bg -> menu-submenu-item-active-background-color
menu-submenu-active-border-color -> menu-submenu-item-active-border-color
menu-submenu-hover-fg -> menu-item-hover-text-color
menu-submenu-hover-bg -> menu-item-hover-background-color
menu-group-fg -> menu-group-text-color
menu-item-separator -> menu-item-divider-color
menu-icon-font-size -> menu-item-icon-width
menu-icon-margin -> menu-item-icon-margin
menu-icon-color -> menu-item-icon-color
menu-icon-active-color -> menu-item-icon-active-color

Following theme properties were removed:
menu-submenu-active-shadow
menu-active-font-weight
menu-submenu-item-container-padding
menu-group-font-weight
menu-group-font-size
menu-group-padding

BREAKING CHANGE:

Following theme variables were removed:
menu-font-family -> menu-text-font-family
menu-font-size -> menu-text-font-size
menu-font-weight -> menu-text-font-weight
menu-fg -> menu-text-color
menu-bg -> menu-background-color
menu-active-fg -> menu-item-active-text-color
menu-active-bg -> menu-item-active-background-color
menu-submenu-bg -> menu-submenu-background-color
menu-submenu-fg -> menu-submenu-text-color
menu-submenu-active-fg -> menu-submenu-item-active-text-color
menu-submenu-active-bg -> menu-submenu-item-active-background-color
menu-submenu-active-border-color -> menu-submenu-item-active-border-color
menu-submenu-hover-fg -> menu-item-hover-text-color
menu-submenu-hover-bg -> menu-item-hover-background-color
menu-group-fg -> menu-group-text-color
menu-item-separator -> menu-item-divider-color
menu-icon-font-size -> menu-item-icon-width
menu-icon-margin -> menu-item-icon-margin
menu-icon-color -> menu-item-icon-color
menu-icon-active-color -> menu-item-icon-active-color

Following theme properties were removed:
menu-submenu-active-shadow
menu-active-font-weight
menu-submenu-item-container-padding
menu-group-font-weight
menu-group-font-size
menu-group-padding
@yggg yggg requested a review from nnixaa April 25, 2019 11:02
@yggg yggg changed the title Feat/eva menu feat(menu): Eva style Apr 25, 2019
@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #1421 into next will increase coverage by <.01%.
The diff coverage is 80.95%.

@@            Coverage Diff             @@
##             next    #1421      +/-   ##
==========================================
+ Coverage   82.61%   82.62%   +<.01%     
==========================================
  Files         238      238              
  Lines        7295     7293       -2     
  Branches      651      651              
==========================================
- Hits         6027     6026       -1     
+ Misses       1080     1079       -1     
  Partials      188      188
Impacted Files Coverage Δ
.../framework/theme/components/menu/menu.component.ts 73.17% <80.95%> (+0.37%) ⬆️

@yggg yggg merged commit 7a84733 into akveo:next Apr 25, 2019
yggg added a commit that referenced this pull request May 27, 2019
BREAKING CHANGE:

Removed inverse mode.

NbMenuComponent 'autoCollapseValue' property changed to 'autoCollapse'.

Following theme variables were removed:
menu-font-family -> menu-text-font-family
menu-font-size -> menu-text-font-size
menu-font-weight -> menu-text-font-weight
menu-fg -> menu-text-color
menu-bg -> menu-background-color
menu-active-fg -> menu-item-active-text-color
menu-active-bg -> menu-item-active-background-color
menu-submenu-bg -> menu-submenu-background-color
menu-submenu-fg -> menu-submenu-text-color
menu-submenu-active-fg -> menu-submenu-item-active-text-color
menu-submenu-active-bg -> menu-submenu-item-active-background-color
menu-submenu-active-border-color -> menu-submenu-item-active-border-color
menu-submenu-hover-fg -> menu-item-hover-text-color
menu-submenu-hover-bg -> menu-item-hover-background-color
menu-group-fg -> menu-group-text-color
menu-item-separator -> menu-item-divider-color
menu-icon-font-size -> menu-item-icon-width
menu-icon-margin -> menu-item-icon-margin
menu-icon-color -> menu-item-icon-color
menu-icon-active-color -> menu-item-icon-active-color

Following theme properties were removed:
menu-submenu-active-shadow
menu-active-font-weight
menu-submenu-item-container-padding
menu-group-font-weight
menu-group-font-size
menu-group-padding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants