Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): Eva style #1408

Merged
merged 22 commits into from
Apr 24, 2019
Merged

feat(chat): Eva style #1408

merged 22 commits into from
Apr 24, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 21, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Also closes #1118.

BREAKING CHANGE:

NbChatComponent 'accent' field removed.

NbChatComponent sizes 'xxsmall' and 'xxlarge' removed.
'xsmall' size changed to 'tiny', 'xlarge' changed to 'giant'.
Size class changed to 'size-[size-name]'.
All size static fields removed (SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL,
SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE).

NbChatComponent 'active' status removed.

Disabled status removed. Use disabled input instead.

Status class names changed to 'status-[status-name]'.

NbChatMessageComponent 'replyValue' changed to 'reply'.

Following theme properties removed:

chat-font-size -> chat-text-font-size
chat-fg -> chat-text-color
chat-bg -> chat-background-color
chat-height-xsmall -> chat-tiny-height
chat-height-small -> chat-small-height
chat-height-medium -> chat-medium-height
chat-height-large -> chat-large-height
chat-height-xlarge -> chat-giant-height
chat-separator -> chat-divider-color
chat-message-fg -> chat-message-text-color
chat-message-bg -> chat-message-background
chat-message-reply-bg -> chat-message-reply-background-color
chat-message-reply-fg -> chat-message-reply-text-color
chat-message-avatar-bg -> chat-message-avatar-background-color
chat-message-sender-fg -> chat-message-sender-text-color
chat-message-quote-fg -> chat-message-quote-background-color
chat-message-quote-bg -> chat-message-quote-text-color
chat-message-file-fg -> chat-message-file-text-color
chat-message-file-bg -> chat-message-file-background-color
chat-primary-bg -> chat-primary-background-color
chat-success-bg -> chat-success-background-color
chat-info-bg -> chat-info-background-color
chat-warning-bg -> chat-warning-background-color
chat-danger-bg -> chat-danger-background-color

Following theme properties removed:

chat-fg-text
chat-height-xxsmall
chat-height-xxlarge
chat-form-bg
chat-form-fg
chat-form-border
chat-form-placeholder-fg
chat-form-active-border
chat-disabled-bg
chat-disabled-fg
chat-active-bg

yggg added 16 commits April 21, 2019 12:33
Accent wasn't implemented, it was just field and class without any
styles.

BREAKING CHANGE:

NbChatComponent 'accent' field removed.
BREAKING CHANGE:

NbChatComponent sizes 'xxsmall' and 'xxlarge' removed.
'xsmall' size changed to 'tiny', 'xlarge' changed to 'giant'.
Size class changed to 'size-[size-name]'.
All size static fields removed (SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL,
SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE).
BREAKING CHANGE:

NbChatComponent 'active' status removed.

Disabled status removed. Use disabled input instead.

Status class names changed to 'status-[status-name]'.

All status static fields removed (STATUS_ACTIVE, STATUS_DISABLED, STATUS_PRIMARY,
STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING, STATUS_DANGER).
BREAKING CHANGE:

NbChatMessageComponent 'replyValue' changed to 'reply'.
BREAKING CHANGE:

Following theme properties removed:

chat-font-size -> chat-text-font-size
chat-fg -> chat-text-color
chat-bg -> chat-background-color
chat-height-xsmall -> chat-tiny-height
chat-height-small -> chat-small-height
chat-height-medium -> chat-medium-height
chat-height-large -> chat-large-height
chat-height-xlarge -> chat-giant-height
chat-separator -> chat-divider-color
chat-message-fg -> chat-message-text-color
chat-message-bg -> chat-message-background
chat-message-reply-bg -> chat-message-reply-background-color
chat-message-reply-fg -> chat-message-reply-text-color
chat-message-avatar-bg -> chat-message-avatar-background-color
chat-message-sender-fg -> chat-message-sender-text-color
chat-message-quote-fg -> chat-message-quote-background-color
chat-message-quote-bg -> chat-message-quote-text-color
chat-message-file-fg -> chat-message-file-text-color
chat-message-file-bg -> chat-message-file-background-color
chat-primary-bg -> chat-primary-background-color
chat-success-bg -> chat-success-background-color
chat-info-bg -> chat-info-background-color
chat-warning-bg -> chat-warning-background-color
chat-danger-bg -> chat-danger-background-color

Following theme properties removed:

chat-fg-text
chat-height-xxsmall
chat-height-xxlarge
chat-form-bg
chat-form-fg
chat-form-border
chat-form-placeholder-fg
chat-form-active-border
chat-disabled-bg
chat-disabled-fg
chat-active-bg
@yggg yggg requested a review from nnixaa April 21, 2019 14:47
nnixaa
nnixaa previously approved these changes Apr 22, 2019
@nnixaa
Copy link
Collaborator

nnixaa commented Apr 22, 2019

Oh can we fix this one as part of this refactoring #1118?

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #1408 into next will decrease coverage by 0.11%.
The diff coverage is 41.17%.

@@            Coverage Diff             @@
##             next    #1408      +/-   ##
==========================================
- Coverage   82.63%   82.51%   -0.12%     
==========================================
  Files         238      238              
  Lines        7285     7281       -4     
  Branches      642      647       +5     
==========================================
- Hits         6020     6008      -12     
- Misses       1076     1084       +8     
  Partials      189      189
Impacted Files Coverage Δ
...me/components/chat/chat-message-quote.component.ts 100% <ø> (ø) ⬆️
...eme/components/chat/chat-message-text.component.ts 100% <ø> (ø) ⬆️
...heme/components/chat/chat-message-map.component.ts 83.33% <ø> (ø) ⬆️
...eme/components/chat/chat-message-file.component.ts 52.94% <0%> (ø) ⬆️
...ework/theme/components/chat/chat-form.component.ts 32.69% <12.5%> (-2.1%) ⬇️
...rk/theme/components/chat/chat-message.component.ts 63.33% <16.66%> (-5.64%) ⬇️
.../framework/theme/components/chat/chat.component.ts 53.7% <48.97%> (-8.62%) ⬇️
src/framework/theme/components/chat/chat.module.ts 81.81% <50%> (-7.08%) ⬇️

@yggg yggg merged commit 98b51c0 into akveo:next Apr 24, 2019
yggg added a commit that referenced this pull request May 27, 2019
BREAKING CHANGE:

NbChatComponent 'accent' field removed.

NbChatComponent sizes 'xxsmall' and 'xxlarge' removed.
'xsmall' size changed to 'tiny', 'xlarge' changed to 'giant'.
Size class changed to 'size-[size-name]'.
All size static fields removed (SIZE_XXSMALL, SIZE_XSMALL, SIZE_SMALL,
SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE, SIZE_XXLARGE).

NbChatComponent 'active' status removed.

Disabled status removed. Use disabled input instead.

Status class names changed to 'status-[status-name]'.

NbChatMessageComponent 'replyValue' changed to 'reply'.

Following theme properties removed:

chat-font-size -> chat-text-font-size
chat-fg -> chat-text-color
chat-bg -> chat-background-color
chat-height-xsmall -> chat-tiny-height
chat-height-small -> chat-small-height
chat-height-medium -> chat-medium-height
chat-height-large -> chat-large-height
chat-height-xlarge -> chat-giant-height
chat-separator -> chat-divider-color
chat-message-fg -> chat-message-text-color
chat-message-bg -> chat-message-background
chat-message-reply-bg -> chat-message-reply-background-color
chat-message-reply-fg -> chat-message-reply-text-color
chat-message-avatar-bg -> chat-message-avatar-background-color
chat-message-sender-fg -> chat-message-sender-text-color
chat-message-quote-fg -> chat-message-quote-background-color
chat-message-quote-bg -> chat-message-quote-text-color
chat-message-file-fg -> chat-message-file-text-color
chat-message-file-bg -> chat-message-file-background-color
chat-primary-bg -> chat-primary-background-color
chat-success-bg -> chat-success-background-color
chat-info-bg -> chat-info-background-color
chat-warning-bg -> chat-warning-background-color
chat-danger-bg -> chat-danger-background-color

Following theme properties removed:

chat-fg-text
chat-height-xxsmall
chat-height-xxlarge
chat-form-bg
chat-form-fg
chat-form-border
chat-form-placeholder-fg
chat-form-active-border
chat-disabled-bg
chat-disabled-fg
chat-active-bg
@yggg yggg mentioned this pull request Aug 6, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants