Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(badge): Eva theme #1407

Merged
merged 13 commits into from
Apr 22, 2019
Merged

feat(badge): Eva theme #1407

merged 13 commits into from
Apr 22, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 21, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGE:

NbBadgeComponent status static fields removed.
STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING,
STATUS_DANGER.

NbBadgeComponent position static fields replaced with NbBadgePosition type.
Removed properties: TOP_LEFT, TOP_RIGHT, BOTTOM_LEFT, BOTTOM_RIGHT,
TOP_START, TOP_END, BOTTOM_START, BOTTOM_END.

Badge status class now set on host element

NbBadgeComponent 'positionClass' getter removed.
Badge position class set on host element.
Position class names prefixed with 'position-'.

Following theme properties were renamed:
badge-fg-text -> badge-[status]-text-color
badge-primary-bg-color -> badge-primary-background-color
badge-success-bg-color -> badge-success-background-color
badge-info-bg-color -> badge-info-background-color
badge-warning-bg-color -> badge-warning-background-color
badge-danger-bg-color -> badge-danger-background-color

BREAKING CHANGE:

NbBadgeComponent status static fields removed.
STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING,
STATUS_DANGER.
BREAKING CHANGE:

NbBadgeComponent position static fields replaced with NbBadgePosition type.
Removed properties: TOP_LEFT, TOP_RIGHT, BOTTOM_LEFT, BOTTOM_RIGHT,
TOP_START, TOP_END, BOTTOM_START, BOTTOM_END.
BREAKING CHANGE:

Badge status class now set on host element
Logical badge position now calculated via css.

BREAKING CHANGE:

NbBadgeComponent 'positionClass' getter removed.
Badge position class set on host element.
Position class names prefixed with 'position-'.
BREAKING CHANGE:

Following theme properties were renamed:
badge-fg-text -> badge-[status]-text-color
badge-primary-bg-color -> badge-primary-background-color
badge-success-bg-color -> badge-success-background-color
badge-info-bg-color -> badge-info-background-color
badge-warning-bg-color -> badge-warning-background-color
badge-danger-bg-color -> badge-danger-background-color
@yggg yggg requested a review from nnixaa April 21, 2019 09:20
nnixaa
nnixaa previously approved these changes Apr 22, 2019
@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #1407 into next will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next    #1407      +/-   ##
==========================================
+ Coverage   82.68%   82.71%   +0.03%     
==========================================
  Files         238      238              
  Lines        7227     7228       +1     
  Branches      637      634       -3     
==========================================
+ Hits         5976     5979       +3     
  Misses       1064     1064              
+ Partials      187      185       -2
Impacted Files Coverage Δ
.../components/progress-bar/progress-bar.component.ts 100% <ø> (ø) ⬆️
...ramework/theme/components/badge/badge.component.ts 100% <100%> (+6.45%) ⬆️
...mework/theme/components/tabset/tabset.component.ts 54.16% <100%> (ø) ⬆️
.../framework/theme/components/user/user.component.ts 100% <100%> (ø) ⬆️
...work/theme/components/actions/actions.component.ts 100% <100%> (ø) ⬆️

@yggg yggg requested a review from nnixaa April 22, 2019 11:42
@yggg yggg merged commit 95767cf into akveo:next Apr 22, 2019
yggg added a commit that referenced this pull request May 27, 2019
BREAKING CHANGE:

NbBadgeComponent status static fields removed.
STATUS_PRIMARY, STATUS_INFO, STATUS_SUCCESS, STATUS_WARNING,
STATUS_DANGER.

NbBadgeComponent position static fields replaced with NbBadgePosition type.
Removed properties: TOP_LEFT, TOP_RIGHT, BOTTOM_LEFT, BOTTOM_RIGHT,
TOP_START, TOP_END, BOTTOM_START, BOTTOM_END.

Badge status class now set on host element

NbBadgeComponent 'positionClass' getter removed.
Badge position class set on host element.
Position class names prefixed with 'position-'.

Following theme properties were renamed:
badge-fg-text -> badge-[status]-text-color
badge-primary-bg-color -> badge-primary-background-color
badge-success-bg-color -> badge-success-background-color
badge-info-bg-color -> badge-info-background-color
badge-warning-bg-color -> badge-warning-background-color
badge-danger-bg-color -> badge-danger-background-color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants