Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlay): set context on component portals before first cd run #1395

Merged
merged 1 commit into from
Apr 19, 2019
Merged

fix(overlay): set context on component portals before first cd run #1395

merged 1 commit into from
Apr 19, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 18, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes #1261

@yggg yggg requested a review from Tibing April 18, 2019 13:16
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #1395 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1395   +/-   ##
=======================================
  Coverage   81.84%   81.84%           
=======================================
  Files         232      232           
  Lines        7067     7067           
  Branches      599      600    +1     
=======================================
  Hits         5784     5784           
  Misses       1104     1104           
  Partials      179      179
Impacted Files Coverage Δ
...mework/theme/components/window/window.component.ts 84.21% <100%> (-0.28%) ⬇️
...work/theme/components/popover/popover.component.ts 100% <100%> (ø) ⬆️
.../theme/components/cdk/overlay/overlay-container.ts 100% <100%> (ø) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbWindowService - context no longer works
2 participants