fix(cdk): fix scroll blocker for custom withScroll mode
#1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1364 +/- ##
==========================================
- Coverage 81.17% 81.11% -0.06%
==========================================
Files 232 232
Lines 7049 7054 +5
Branches 598 599 +1
==========================================
Hits 5722 5722
- Misses 1151 1156 +5
Partials 176 176
|
Tibing
reviewed
Apr 10, 2019
| @@ -442,8 +442,22 @@ export class NbLayoutComponent implements AfterViewInit, OnDestroy { | |||
| .pipe( | |||
| filter(() => this.withScrollValue), | |||
| ) | |||
| .subscribe((scrollable: boolean) => { | |||
| .subscribe((scrollable) => { | |||
There was a problem hiding this comment.
Let's return type declaration here:
Suggested change
| .subscribe((scrollable) => { | |
| .subscribe((scrollable: boolean) => { |
| * so that it won't add additional positioning. | ||
| */ | ||
| if (!scrollable) { | ||
| root.classList.add(scrollBlockClass); |
There was a problem hiding this comment.
It would be better to use renderer here:
Suggested change
| root.classList.add(scrollBlockClass); | |
| this.renderer.addClass(root, scrollBlockClass); |
| if (!scrollable) { | ||
| root.classList.add(scrollBlockClass); | ||
| } else { | ||
| root.classList.remove(scrollBlockClass); |
There was a problem hiding this comment.
It would be better to use renderer here:
Suggested change
| root.classList.remove(scrollBlockClass); | |
| this.renderer.removeClass(root, scrollBlockClass); |
| * we need to disable default CDK scroll blocker (@link NbBlockScrollStrategyAdapter) on HTML element | ||
| * so that it won't add additional positioning. | ||
| */ | ||
| .nebular-global-scrollblock { |
There was a problem hiding this comment.
I think it has to be:
Suggested change
| .nebular-global-scrollblock { | |
| .nb-global-scrollblock { |
Tibing
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1158, Closes #1259