fix(select): prevent dispose call on uninitialized properties #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yggg
changed the title
nnixaa
requested changes
Apr 8, 2019
| @@ -281,6 +281,11 @@ describe('Component: NbSelectComponent', () => { | |||
| expect(selectButton.textContent).toEqual(selectedOption.value.toString()); | |||
| })); | |||
|
|
|||
| it(`should not call dispose on initialized resources`, () => { | |||
There was a problem hiding this comment.
Right, fixed in d8a2d4e.
nnixaa
approved these changes
Apr 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
+ Coverage 81.13% 81.14% +<.01%
==========================================
Files 232 232
Lines 7046 7048 +2
Branches 596 598 +2
==========================================
+ Hits 5717 5719 +2
Misses 1152 1152
Partials 177 177
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Fixes case when component was destroyed before calling init hook.