feat(toggle): add toggle component #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1304 +/- ##
==========================================
+ Coverage 83.88% 83.97% +0.08%
==========================================
Files 232 234 +2
Lines 7595 7674 +79
Branches 670 672 +2
==========================================
+ Hits 6371 6444 +73
- Misses 1027 1032 +5
- Partials 197 198 +1
|
nnixaa
requested changes
Mar 18, 2019
src/framework/theme/components/toggle/_toggle.component.theme.scss
Outdated
Show resolved
Hide resolved
nnixaa
previously requested changes
Jun 6, 2019
yggg
suggested changes
Jul 17, 2019
src/framework/theme/components/toggle/_toggle.component.theme.scss
Outdated
Show resolved
Hide resolved
yggg
suggested changes
Jul 18, 2019
yggg
suggested changes
Jul 24, 2019
src/framework/theme/components/toggle/_toggle.component.theme.scss
Outdated
Show resolved
Hide resolved
yggg
suggested changes
Jul 24, 2019
yggg
suggested changes
Jul 25, 2019
yggg
suggested changes
Jul 29, 2019
src/framework/theme/components/toggle/_toggle.component.theme.scss
Outdated
Show resolved
Hide resolved
src/framework/theme/components/toggle/_toggle.component.theme.scss
Outdated
Show resolved
Hide resolved
yggg
reviewed
Jul 29, 2019
src/playground/with-layout/toggle/toggle-label-position.component.ts
Outdated
Show resolved
Hide resolved
added 10 commits
July 30, 2019 10:21
in test. small improvements
unused elements in showcase
yggg
suggested changes
Jul 31, 2019
Should fix Chrome version error
This reverts commit 754138c as a fix extracted into separate PR
yggg
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Toggle component added. Closes #778