Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): update selected after cd run is finished #1299

Merged
merged 4 commits into from
Mar 14, 2019
Merged

fix(select): update selected after cd run is finished #1299

merged 4 commits into from
Mar 14, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Mar 13, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes #1157

@yggg yggg requested a review from nnixaa March 13, 2019 14:30
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #1299 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1299      +/-   ##
==========================================
+ Coverage    79.9%   79.98%   +0.07%     
==========================================
  Files         232      232              
  Lines        7032     7033       +1     
  Branches      590      590              
==========================================
+ Hits         5619     5625       +6     
+ Misses       1244     1241       -3     
+ Partials      169      167       -2
Impacted Files Coverage Δ
...mework/theme/components/select/select.component.ts 87.3% <100%> (+2.72%) ⬆️

@yggg yggg mentioned this pull request Mar 13, 2019
1 task
@yggg yggg merged commit 2a1f113 into akveo:master Mar 14, 2019
@yggg yggg mentioned this pull request Apr 11, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbSelect Change Detection Issue
2 participants